-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add otel plumbing & grpc instrumentation #514
Conversation
looks like sonatype-lift bot is over-sensitive to transitive checksums in go.sum otel-init-go is using the newest version of OpenTelemetry and gRPC, newer than what was here before. Most of the things it's "detecting" are way out in the leaves of dependencies and as far as I can tell, do not actually get included in the binary produced. |
Signed-off-by: Amy Tobey <atobey@equinix.com>
Seems to ditch some other old dependencies and make go vet happy. Signed-off-by: Amy Tobey <atobey@equinix.com>
Fixing up those build fails, will need another review after @tstromberg :) |
While going through OSIE I realized I need to do some work in tink-worker and started that. I can tack that onto this PR or follow up. I should have something to look at in the middle of next week. |
Let's put that into a follow-up PR. |
Codecov Report
@@ Coverage Diff @@
## master #514 +/- ##
==========================================
- Coverage 33.61% 33.59% -0.02%
==========================================
Files 44 44
Lines 3385 3387 +2
==========================================
Hits 1138 1138
- Misses 2150 2152 +2
Partials 97 97
Continue to review full report at Codecov.
|
Can you run
(cue rant about linting markdown docs...) |
Signed-off-by: Amy Tobey <atobey@equinix.com>
I've pushed up the prettier changes @tstromberg |
Wow, fun. This is totally breaking my branch. I'll figure it out. |
Description
This PR adds OpenTelemetry plumbing and gRPC instrumentation to tink. When configured as described in the README, this will cause tink components to emit otel tracing data to the configured service, which enables observability of requests across tink components.
Note: I couldn't seem to avoid updating some dependencies when I made these changes so there are some mostly-unrelated changes due to that, most notably, the Docker library and required API changes.
How Has This Been Tested?
Current tests seem to pass. Still need to add more tests which is why this is a draft PR for now.
How are existing users impacted? What migration steps/scripts do we need?
Currently the only way to trace requests across the tink stack is with logs and we'd like to improve on that.
Checklist:
I have: