Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use newer alpine #560

Merged
merged 1 commit into from
Nov 24, 2021
Merged

Use newer alpine #560

merged 1 commit into from
Nov 24, 2021

Conversation

swills
Copy link
Contributor

@swills swills commented Nov 24, 2021

Quay.io security scanner reports issues with the busybox in this version
of alpine, use latest

Description

See quay.io security scanner report for example:

https://quay.io/repository/tinkerbell/tink-cli/manifest/sha256:654051f51bd9a8c6cb38e5afe46689aeff086cb03f876cd4714a72088e194308?tab=vulnerabilities

Why is this needed

See above

How Has This Been Tested?

Going to wait for the github action to test it

How are existing users impacted? What migration steps/scripts do we need?

Should be no impact

Checklist:

I have:

  • [N/A] updated the documentation and/or roadmap (if required)
  • [N/A] added unit or e2e tests
  • [N/A] provided instructions on how to upgrade

@thebsdbox
Copy link
Contributor

Good catch. There's a lot we need to look at automating.

@codecov
Copy link

codecov bot commented Nov 24, 2021

Codecov Report

Merging #560 (e07114a) into main (4900279) will not change coverage.
The diff coverage is n/a.

❗ Current head e07114a differs from pull request most recent head b296ba2. Consider uploading reports for the commit b296ba2 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #560   +/-   ##
=======================================
  Coverage   34.76%   34.76%           
=======================================
  Files          44       44           
  Lines        3348     3348           
=======================================
  Hits         1164     1164           
  Misses       2085     2085           
  Partials       99       99           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4900279...b296ba2. Read the comment docs.

Quay.io security scanner reports issues with the busybox in this version
of alpine, use latest

Signed-off-by: Steve Wills <steve@mouf.net>
Copy link
Member

@jacobweinstock jacobweinstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@jacobweinstock jacobweinstock merged commit 058a1c9 into tinkerbell:main Nov 24, 2021
@displague displague added this to the 0.7.0 milestone Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants