Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated repository config files #565

Merged
merged 1 commit into from
Dec 3, 2021

Conversation

micahhausler
Copy link
Contributor

Signed-off-by: Micah Hausler mhausler@amazon.com

Description

Extracted repo config changes from #563

Why is this needed

  • Go version is out of date in ci.yaml
  • .mk files were missing from editor config
  • Coverage was counted against for generated files

Fixes: #

N/A

How Has This Been Tested?

Ran verify/tests locally

How are existing users impacted? What migration steps/scripts do we need?

N/A

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

@micahhausler micahhausler requested a review from mmlb December 3, 2021 21:50
@codecov
Copy link

codecov bot commented Dec 3, 2021

Codecov Report

Merging #565 (a47a292) into main (64200ed) will not change coverage.
The diff coverage is n/a.

❗ Current head a47a292 differs from pull request most recent head 51226f3. Consider uploading reports for the commit 51226f3 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #565   +/-   ##
=======================================
  Coverage   34.76%   34.76%           
=======================================
  Files          44       44           
  Lines        3348     3348           
=======================================
  Hits         1164     1164           
  Misses       2085     2085           
  Partials       99       99           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64200ed...51226f3. Read the comment docs.

@micahhausler micahhausler force-pushed the repo-updates branch 2 times, most recently from 9a96aac to 78c1839 Compare December 3, 2021 21:58
.github/workflows/ci.yaml Show resolved Hide resolved
.github/workflows/ci.yaml Show resolved Hide resolved
Signed-off-by: Micah Hausler <mhausler@amazon.com>
@mmlb mmlb added the ready-to-merge Signal to Mergify to merge the PR. label Dec 3, 2021
@mergify mergify bot merged commit 5de0768 into tinkerbell:main Dec 3, 2021
@micahhausler micahhausler deleted the repo-updates branch December 9, 2021 20:42
@micahhausler micahhausler mentioned this pull request Jan 10, 2022
3 tasks
@displague displague added this to the 0.7.0 milestone Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants