tink-cli: Add bash to container image #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmlb
force-pushed
the
add-bash-tink-cli-conatiner
branch
from
e93b405 to
ab1b234
Compare
I've recently been bitten by alpine/busybox's ash not properly implementing `[[` as a builtin while doing a bunch of work on sandbox's scripts. Changing over to POSIX sh is an option but not really worth it imo as almost everyone assumes sh == bash already and bash is also nice for interactive use anyway. Bash ends up adding ~2.2MB to the image which I don't think matters, tink-cli isn't going to be used in production all that much and its still pretty small. tink-cli-yes-bash latest 3f59f8e81a34 10 seconds ago 30.4MB tink-cli-no-bash latest e521b3895111 23 seconds ago 28.2MB Signed-off-by: Manuel Mendez <mmendez@equinix.com>
mmlb
force-pushed
the
add-bash-tink-cli-conatiner
branch
from
ab1b234 to
efc33b6
Compare
nshalman
approved these changes
Mar 10, 2022
Codecov Report
@@ Coverage Diff @@
## main #595 +/- ##
=======================================
Coverage 43.41% 43.41%
=======================================
Files 51 52 +1
Lines 3107 3107
=======================================
Hits 1349 1349
Misses 1673 1673
Partials 85 85
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds bash to tink-cli image
Why is this needed
I've recently been bitten by alpine/busybox's ash not properly implementing
[[as a builtin while doing a bunch of work on sandbox's scripts. Changingover to POSIX sh is an option but not really worth it imo as almost everyone
assumes sh == bash already and bash is also nice for interactive use anyway.
Bash ends up adding ~2.2MB to the image which I don't think matters, tink-cli
isn't going to be used in production all that much and its still pretty small.
tink-cli-yes-bash latest 3f59f8e81a34 10 seconds ago 30.4MB
tink-cli-no-bash latest e521b3895111 23 seconds ago 28.2MB
How Has This Been Tested?
Ran container a bunch of different ways.
How are existing users impacted? What migration steps/scripts do we need?
Better tink-cli based scripted stuff?
Checklist:
I have: