-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create an automated release workflow #603
Conversation
/assign @jacobweinstock |
Codecov Report
@@ Coverage Diff @@
## main #603 +/- ##
==========================================
+ Coverage 44.37% 46.22% +1.85%
==========================================
Files 61 56 -5
Lines 3491 3310 -181
==========================================
- Hits 1549 1530 -19
+ Misses 1858 1690 -168
- Partials 84 90 +6
Continue to review full report at Codecov.
|
|
||
For version v0.x.y: | ||
|
||
1. Create the annotated tag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like we'd be okay to use GitHub's release/tag tooling for the same effect? Is that accurate and if so should we say as much, or say why we should not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea was to try to automate the release process. Longer term, I could see a manually triggered workflow could be created to automate the tagging instead of requiring the tag to be created and pushed externally.
b1fddc4
to
4d28931
Compare
4d28931
to
0d57e56
Compare
0d57e56
to
14a8fa4
Compare
- When a tag is created and pushed that has a v prefix: - Automatically generate release notes with github - Push the pre-built sha-based image with a new tag for the version - Automatically create a release in github - Updates the CI workflow to not run on tags with a v prefix Signed-off-by: Jason DeTiberus <detiber@users.noreply.github.com>
14a8fa4
to
f5d1886
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @detiber !
Description
When a tag is created and pushed that has a v prefix:
Updates the CI workflow to not run on tags with a v prefix
I modeled this off the automated process we are currently using for the sandbox releases.
Why is this needed
How Has This Been Tested?
It's the same process as what has been merged to boots in tinkerbell/smee#234