Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an automated release workflow #603

Merged
merged 1 commit into from
May 4, 2022

Conversation

detiber
Copy link
Contributor

@detiber detiber commented Apr 5, 2022

Description

  • When a tag is created and pushed that has a v prefix:

    • Automatically generate release notes with github
    • Push the pre-built sha-based image with a new tag for the version
    • Automatically create a release in github
  • Updates the CI workflow to not run on tags with a v prefix

I modeled this off the automated process we are currently using for the sandbox releases.

Why is this needed

  • Automates the release process, which is currently manual
  • Adds a tagged image associated with the release version

How Has This Been Tested?

It's the same process as what has been merged to boots in tinkerbell/smee#234

@detiber
Copy link
Contributor Author

detiber commented Apr 5, 2022

/assign @jacobweinstock

@codecov
Copy link

codecov bot commented Apr 5, 2022

Codecov Report

Merging #603 (e7957c5) into main (720195f) will increase coverage by 1.85%.
The diff coverage is n/a.

❗ Current head e7957c5 differs from pull request most recent head f5d1886. Consider uploading reports for the commit f5d1886 to get more accurate results

@@            Coverage Diff             @@
##             main     #603      +/-   ##
==========================================
+ Coverage   44.37%   46.22%   +1.85%     
==========================================
  Files          61       56       -5     
  Lines        3491     3310     -181     
==========================================
- Hits         1549     1530      -19     
+ Misses       1858     1690     -168     
- Partials       84       90       +6     
Impacted Files Coverage Δ
cmd/tink-cli/cmd/delete/delete.go 67.44% <0.00%> (-18.28%) ⬇️
grpc-server/grpc_server.go 75.60% <0.00%> (-17.50%) ⬇️
cmd/tink-cli/cmd/get/get.go 70.00% <0.00%> (-9.17%) ⬇️
server/dbserver_hardware.go 2.40% <0.00%> (-0.05%) ⬇️
server/dbserver.go 0.00% <0.00%> (ø)
cmd/tink-worker/worker/worker.go 0.00% <0.00%> (ø)
cmd/tink-worker/worker/registry.go 80.76% <0.00%> (ø)
pkg/controllers/workflow/controller.go 73.68% <0.00%> (ø)
pkg/apis/core/v1alpha1/workflow_methods.go 76.27% <0.00%> (ø)
internal/tests/errors.go
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 720195f...f5d1886. Read the comment docs.


For version v0.x.y:

1. Create the annotated tag
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like we'd be okay to use GitHub's release/tag tooling for the same effect? Is that accurate and if so should we say as much, or say why we should not?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea was to try to automate the release process. Longer term, I could see a manually triggered workflow could be created to automate the tagging instead of requiring the tag to be created and pushed externally.

@detiber detiber force-pushed the automateRelease branch 2 times, most recently from b1fddc4 to 4d28931 Compare April 7, 2022 13:50
jacobweinstock
jacobweinstock previously approved these changes Apr 28, 2022
- When a tag is created and pushed that has a v prefix:
  - Automatically generate release notes with github
  - Push the pre-built sha-based image with a new tag for the version
  - Automatically create a release in github

- Updates the CI workflow to not run on tags with a v prefix

Signed-off-by: Jason DeTiberus <detiber@users.noreply.github.com>
Copy link
Member

@jacobweinstock jacobweinstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @detiber !

@jacobweinstock jacobweinstock added the ready-to-merge Signal to Mergify to merge the PR. label May 4, 2022
@mergify mergify bot merged commit e184cbc into tinkerbell:main May 4, 2022
@displague displague added this to the 0.7.0 milestone Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants