Move to path.Join for repo + image_name: #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #607 +/- ##
=======================================
Coverage 45.86% 45.86%
=======================================
Files 56 56
Lines 3268 3268
=======================================
Hits 1499 1499
Misses 1686 1686
Partials 83 83
Continue to review full report at Codecov.
|
jacobweinstock
force-pushed
the
update-worker-registry
branch
from
29fb85d to
21a4978
Compare
3 tasks
|
Hey @mmlb. When you have a few moments, would you mind checking this out? |
|
LGTM, sorry for not reviewing but I really didn't want to have something jump in front of #584 and dropping reviews and thus prolonging it even more. |
With this a tink-worker can be started without a registry defined and templates in Tink server can specify any registry. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
jacobweinstock
force-pushed
the
update-worker-registry
branch
from
21a4978 to
442fabd
Compare
mmlb
approved these changes
Apr 18, 2022
mergify bot
added a commit
to tinkerbell/smee
that referenced
this pull request
Apr 18, 2022
) ## Description Allow registry, registry username, and password to be empty strings. These values are passed as kernel command line args for OSIE's boot up and then used by Tink worker when it pulls and runs containers. With [this](tinkerbell/tink#607) change to Tink worker, allowing the empty string here provides Tink worker the ability to specify any fully qualified container image in a template. e.g. `docker.io/alpine`, `quay.io/tinkerbell-actions/cexec`, `public.ecr.aws/l0g8r8j6/tinkerbell/pbnj`, etc This change is backward compatible and shouldn't negatively affect using the Cacher backend. ## Why is this needed Fixes: # ## How Has This Been Tested? ## How are existing users impacted? What migration steps/scripts do we need? ## Checklist: I have: - [ ] updated the documentation and/or roadmap (if required) - [ ] added unit or e2e tests - [ ] provided instructions on how to upgrade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With this a tink-worker can be started without a registry defined and templates in Tink server can specify any registry.
Why is this needed
Currently, if a container registry is not specified then the container image will start with a
/. This will cause tink worker to fail to pull/run the container. With this change, if a container registry is not specified the/will not be added and the contain image will be pulled from the container runtime's default registry. For containerd and docker (which is what Hook runs) the default registry isdocker.io.Fixes: #
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: