Add RBAC for tink-controller and tink-server #610
Conversation
abhinavmpandey08
force-pushed
the
add-rbac
branch
from
c5bac71 to
57bcea0
Compare
| - configmaps | ||
| verbs: | ||
| - get | ||
| - list | ||
| - watch | ||
| - create | ||
| - update | ||
| - patch | ||
| - delete |
There was a problem hiding this comment.
Why are full config map permissions required in the namespace?
There was a problem hiding this comment.
This role is auto-generated by kubebuilder. I am not sure if all these permissions are really required during leader-election or not. Will check and update here
There was a problem hiding this comment.
Alright I just tested and looks like it needs all the permissions on cm except for delete
Codecov Report
@@ Coverage Diff @@
## main #610 +/- ##
=======================================
Coverage 44.37% 44.37%
=======================================
Files 61 61
Lines 3491 3491
=======================================
Hits 1549 1549
Misses 1858 1858
Partials 84 84
Continue to review full report at Codecov.
|
abhinavmpandey08
force-pushed
the
add-rbac
branch
5 times, most recently
from
c58ea83 to
56183d0
Compare
|
@mmlb, can you check this out? approve the workflow run? |
There was a problem hiding this comment.
The workflow is green and the changes LGTM. Will wait for @mmlb's review though.
Signed-off-by: Abhinav Pandey <abhinavmpandey08@gmail.com>
jacobweinstock
force-pushed
the
add-rbac
branch
from
b48d0da to
83240cd
Compare
Description
This PR adds all deployment and RBAC manifests and
kustomization.yamls fortink-controllerandtink-server.Why is this needed
This is needed to help users deploy the kubified tink services in their Kubernetes environment
This is what the generated manifest looks like after running
kustomize build config/defaulthttps://gist.github.com/abhinavmpandey08/ed00314e4b738cacbad67ea9e345ec2aHow Has This Been Tested?
This has been tested by applying the manifests on a KinD cluster and verifying that
tink-controllerandtink-serverboth work as intended.How are existing users impacted? What migration steps/scripts do we need?
No user impact
Checklist:
I have: