Add repo roles: #611
Add repo roles: #611
Conversation
jacobweinstock
force-pushed
the
role-bootstrap
branch
2 times, most recently
from
0afceb2 to
34833fb
Compare
Codecov Report
@@ Coverage Diff @@
## main #611 +/- ##
=======================================
Coverage 44.39% 44.39%
=======================================
Files 61 61
Lines 3489 3489
=======================================
Hits 1549 1549
Misses 1857 1857
Partials 83 83 Continue to review full report at Codecov.
|
.github/settings.yml
Outdated
| collaborators: | ||
| # Maintainers | ||
| - username: mmlb | ||
| permission: maintain | ||
| - username: micahhausler | ||
| permission: maintain | ||
| # Approvers | ||
| - username: jacobweinstock | ||
| permission: push | ||
| - username: tstromberg | ||
| permission: push | ||
| - username: displague | ||
| permission: push | ||
| - username: nshalman | ||
| permission: push | ||
| # Reviewers | ||
| - username: tobert | ||
| permission: triage | ||
| - username: stephen-fox | ||
| permission: triage | ||
| - username: chrisdoherty4 | ||
| permission: triage | ||
| - username: detiber | ||
| permission: triage |
There was a problem hiding this comment.
What do you think about this form?
collaborators:
# Maintainers
- { permission: maintain, username: micahhausler }
- { permission: maintain, username: mmlb }
# Approvers
- { permission: push, username: displague }
- { permission: push, username: jacobweinstock }
- { permission: push, username: nshalman }
- { permission: push, username: tstromberg }
# Reviewers
- { permission: triage, username: chrisdoherty4 }
- { permission: triage, username: detiber }
- { permission: triage, username: stephen-fox }
- { permission: triage, username: tobert }I like it because the groups are more obvious this way.
There was a problem hiding this comment.
There are some readability perks, but I think they are marginal (🥁 ).
I'm fine with the original (boring) yaml list, fwiw.
There was a problem hiding this comment.
no one ever got fired for picking vanilla :) Lets just go with the original.
.github/settings.yml
Outdated
| - username: mmlb | ||
| permission: maintain | ||
| - username: micahhausler | ||
| permission: maintain |
There was a problem hiding this comment.
Serious question, do we want to alphabetize by GitHub username?
There was a problem hiding this comment.
heh actually alphabetizing is why I looked at the one-line-per to begin with 😄
| # The permission to grant the collaborator. Can be one of: | ||
| # * `pull` - can pull, but not push to or administer this repository. | ||
| # * `push` - can pull and push, but not administer this repository. | ||
| # * `admin` - can pull, push and administer this repository. |
There was a problem hiding this comment.
Let's add a note about CODEOWNERS file importance / role in the admin setting.
jacobweinstock
dismissed stale reviews from micahhausler, displague, and mmlb
via
72886e1
jacobweinstock
force-pushed
the
role-bootstrap
branch
from
34833fb to
72886e1
Compare
jacobweinstock
force-pushed
the
role-bootstrap
branch
from
72886e1 to
c45b75c
Compare
.github/workflows/CODEOWNERS
Outdated
| @@ -0,0 +1,2 @@ | |||
| /.github/settings.yml @mmlb @micahhausler | |||
| /.github/CODEOWNERS @mmlb @micahhausler | |||
There was a problem hiding this comment.
This file is /.github/workflows/CODEOWNERS, should it be /.github/CODEOWNERS
This is needed to enable the repo roles defined by the community here: tinkerbell/org#10 Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
jacobweinstock
force-pushed
the
role-bootstrap
branch
from
c45b75c to
687f652
Compare
Description
This is needed to satisfy the repo roles defined by the community here: tinkerbell/org#10
Why is this needed
Fixes: #
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: