Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Go 1.17 #612

Merged
merged 1 commit into from
May 2, 2022
Merged

Conversation

chrisdoherty4
Copy link
Member

As discussed in the community meeting: this updates the go.mod to use 1.17 keeping up-to-date with the times.

Signed-off-by: Chris Doherty <chris.doherty4@gmail.com>
@chrisdoherty4 chrisdoherty4 force-pushed the feature/go1.17-upgrade branch from 67f5bc1 to 6b5a8ec Compare May 2, 2022 16:14
@codecov
Copy link

codecov bot commented May 2, 2022

Codecov Report

Merging #612 (67f5bc1) into main (5b8f8c4) will not change coverage.
The diff coverage is n/a.

❗ Current head 67f5bc1 differs from pull request most recent head 6b5a8ec. Consider uploading reports for the commit 6b5a8ec to get more accurate results

@@           Coverage Diff           @@
##             main     #612   +/-   ##
=======================================
  Coverage   44.37%   44.37%           
=======================================
  Files          61       61           
  Lines        3491     3491           
=======================================
  Hits         1549     1549           
  Misses       1858     1858           
  Partials       84       84           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b8f8c4...6b5a8ec. Read the comment docs.

Copy link
Contributor

@micahhausler micahhausler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update .golangci.yml references to go 1.16?

@chrisdoherty4
Copy link
Member Author

@micahhausler See tinkerbell/lint-install#43. lint-install propogates settings to all other repositories.

@chrisdoherty4 chrisdoherty4 requested a review from micahhausler May 2, 2022 17:07
Copy link
Contributor

@micahhausler micahhausler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@micahhausler micahhausler added the ready-to-merge Signal to Mergify to merge the PR. label May 2, 2022
@mergify mergify bot merged commit cd86d68 into tinkerbell:main May 2, 2022
@displague displague added this to the 0.7.0 milestone Aug 15, 2022
mergify bot added a commit that referenced this pull request Aug 29, 2022
I'm a maintainer of several other services often related to the Kuberenetes back-end/Kubernetes controllers and I'm taking ownership for a lot of release synchronization making it both appropriate and necessary for me to maintain aspects of the Tink repository.

Requirements:

- I have reviewed the [community membership guidelines](https://github.com/tinkerbell/proposals/blob/main/proposals/0024/GOVERNANCE.md)
- I have [enabled 2FA on my GitHub account](https://github.com/settings/security)
- I have subscribed to the [tinkerbell-contributors e-mail list](https://groups.google.com/g/tinkerbell-contributors)
- I am actively contributing to 1 or more Tinkerbell subprojects

Here is a list of non-trival PRs I have been the primary reviewer on:

#596
#628
#614

I have also made a number of code contributions to this repository, here are a few of them:

#638
#631
#626
#622
#612

I have also raised various issues and am driving the releasing across Tinkerbell including in this repository.

Requesting consideration of expedited responsibilities: yes

Sponsors:

- @mmlb (Maintainer)
- @micahhausler (Maintainer)
- @jacobweinstock (Core contributor in other Tinkerbell repositories)
@chrisdoherty4 chrisdoherty4 deleted the feature/go1.17-upgrade branch May 15, 2023 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants