-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add image substitutions in kustomization instead of doing a patch #617
Conversation
Codecov Report
@@ Coverage Diff @@
## main #617 +/- ##
=======================================
Coverage 44.65% 44.65%
=======================================
Files 61 61
Lines 3509 3509
=======================================
Hits 1567 1567
Misses 1860 1860
Partials 82 82 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do like this way over the {manager|server}_image.yaml from before 👍
309d51f
to
5c6d5a0
Compare
Signed-off-by: Abhinav Pandey <abhinavmpandey08@gmail.com>
5c6d5a0
to
abcc69a
Compare
Description
This PR refactors the
release-manifests
target to usekustomize
to substitute the tink-controller and tink-servers images instead of using patches.Why is this needed
There was a bug in the previous
release-manifests
target where the tink-server image wasn't being updated because its dependencies were all being met already causing it to not be re-build. This PR refactors it to not use the image patches removing the need to update these patch files.How Has This Been Tested?
ran
make release-manifests
and verified that the kustomization.yaml and tink.yaml have the expected outputsHow are existing users impacted? What migration steps/scripts do we need?
No user impact
Checklist:
I have: