Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image substitutions in kustomization instead of doing a patch #617

Merged
merged 2 commits into from
May 4, 2022

Conversation

abhinavmpandey08
Copy link
Contributor

Description

This PR refactors the release-manifests target to use kustomize to substitute the tink-controller and tink-servers images instead of using patches.

Why is this needed

There was a bug in the previous release-manifests target where the tink-server image wasn't being updated because its dependencies were all being met already causing it to not be re-build. This PR refactors it to not use the image patches removing the need to update these patch files.

How Has This Been Tested?

ran make release-manifests and verified that the kustomization.yaml and tink.yaml have the expected outputs

How are existing users impacted? What migration steps/scripts do we need?

No user impact

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

@codecov
Copy link

codecov bot commented May 4, 2022

Codecov Report

Merging #617 (08f6555) into main (a0f65e9) will not change coverage.
The diff coverage is n/a.

❗ Current head 08f6555 differs from pull request most recent head 54dffbb. Consider uploading reports for the commit 54dffbb to get more accurate results

@@           Coverage Diff           @@
##             main     #617   +/-   ##
=======================================
  Coverage   44.65%   44.65%           
=======================================
  Files          61       61           
  Lines        3509     3509           
=======================================
  Hits         1567     1567           
  Misses       1860     1860           
  Partials       82       82           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0f65e9...54dffbb. Read the comment docs.

kube.mk Outdated Show resolved Hide resolved
kube.mk Outdated Show resolved Hide resolved
Copy link
Contributor

@mmlb mmlb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do like this way over the {manager|server}_image.yaml from before 👍

kube.mk Outdated Show resolved Hide resolved
Signed-off-by: Abhinav Pandey <abhinavmpandey08@gmail.com>
@mmlb mmlb added the ready-to-merge Signal to Mergify to merge the PR. label May 4, 2022
@mergify mergify bot merged commit c9ebfa8 into tinkerbell:main May 4, 2022
@displague displague added this to the 0.7.0 milestone Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants