Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make namespace configurable for tink manifest #624

Merged
merged 1 commit into from
May 23, 2022

Conversation

abhinavmpandey08
Copy link
Contributor

Signed-off-by: Abhinav Pandey abhinavmpandey08@gmail.com

Description

Make namespace configurable for tink manifest

Why is this needed

This is needed to allow users to build and deploy the tink manifest in different namespaces

How Has This Been Tested?

ran make release-manifests and verified the changes

How are existing users impacted? What migration steps/scripts do we need?

No existing user impact

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

Signed-off-by: Abhinav Pandey <abhinavmpandey08@gmail.com>
Copy link
Member

@chrisdoherty4 chrisdoherty4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@micahhausler micahhausler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #624 (d019d24) into main (7b60369) will not change coverage.
The diff coverage is n/a.

❗ Current head d019d24 differs from pull request most recent head 660accd. Consider uploading reports for the commit 660accd to get more accurate results

@@           Coverage Diff           @@
##             main     #624   +/-   ##
=======================================
  Coverage   44.52%   44.52%           
=======================================
  Files          61       61           
  Lines        3519     3519           
=======================================
  Hits         1567     1567           
  Misses       1870     1870           
  Partials       82       82           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b60369...660accd. Read the comment docs.

@micahhausler micahhausler added the ready-to-merge Signal to Mergify to merge the PR. label May 23, 2022
@mergify mergify bot merged commit 9bb6d05 into tinkerbell:main May 23, 2022
@displague displague added this to the 0.7.0 milestone Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants