Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"The Culling": Remove deprecated and unused APIs and code #654

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/mergify.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ queue_rules:
conditions:
# Conditions to get out of the queue (= merged)
- check-success=DCO
- check-success~=docker-images.*tink-cli
- check-success~=docker-images.*tink-server
- check-success~=docker-images.*tink-worker

Expand All @@ -15,7 +14,6 @@ pull_request_rules:
- "#changes-requested-reviews-by=0"
- "#review-requested=0"
- check-success=DCO
- check-success~=docker-images.*tink-cli
- check-success~=docker-images.*tink-server
- check-success~=docker-images.*tink-worker
- check-success=crosscompile
Expand Down
12 changes: 0 additions & 12 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -67,9 +67,6 @@ jobs:
- name: Fetch Nix Packages
run: nix-shell --run 'true'

- name: Install gofumpt for ci-checks.sh
run: make bin/gofumpt

- run: PATH=$PWD/bin/:$PATH ./ci-checks.sh
crosscompile:
runs-on: ubuntu-latest
Expand All @@ -88,12 +85,6 @@ jobs:

- run: make crosscompile -j$(nproc)

- name: Upload tink-cli binaries
uses: actions/upload-artifact@v2
with:
name: tink-cli
path: cmd/tink-cli/tink-cli-*

- name: Upload tink-server binaries
uses: actions/upload-artifact@v2
with:
Expand Down Expand Up @@ -124,9 +115,6 @@ jobs:
strategy:
matrix:
include:
- repository: quay.io/tinkerbell/tink-cli
binary: tink-cli

- repository: quay.io/tinkerbell/tink
binary: tink-server

Expand Down
8 changes: 0 additions & 8 deletions .github/workflows/tags.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -59,14 +59,6 @@ jobs:
DST_REG_USER: ${{ secrets.QUAY_USERNAME }}
DST_REG_PASS: ${{ secrets.QUAY_PASSWORD }}

- name: Copy the tink-cli image using skopeo
run: skopeo copy --all --dest-creds="${DST_REG_USER}":"${DST_REG_PASS}" docker://"${SRC_IMAGE}" docker://"${DST_IMAGE}"
env:
SRC_IMAGE: ${{ env.REGISTRY }}/tinkerbell/tink-cli:${{ env.FROM_TAG }}
DST_IMAGE: ${{ env.REGISTRY }}/tinkerbell/tink-cli:${{ fromJSON(steps.meta.outputs.json).labels['org.opencontainers.image.version'] }}
DST_REG_USER: ${{ secrets.QUAY_USERNAME }}
DST_REG_PASS: ${{ secrets.QUAY_PASSWORD }}

- name: Create Release
id: create_release
uses: actions/create-release@v1
Expand Down
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
bin/
certs/
cmd/tink-cli/tink-cli
cmd/tink-controller/tink-controller
cmd/tink-server/tink-server
cmd/tink-worker/tink-worker
Expand Down
64 changes: 0 additions & 64 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -112,74 +112,19 @@ This is a nonexhaustive list important packages that happen to cover most of the

The `cmd` package is home for three core binaries for Tinkerbell:

- `tink-cli` - the CLI for interacting with the `tink-server`
- `tink-server` - the tink API server
- `tink-worker` - responsible for executing the workload

```
.
├── cmd
│   ├── tink-cli
│   │   └── cmd
│   │   ├── delete
│   │   ├── get
│   │   ├── hardware
│   │   ├── template
│   │   └── workflow
│   ├── tink-server
│   └── tink-worker
│   ├── cmd
│   └── internal
```

### db

The `db` holds everything you need to deal with the database.
We use [PostgreSQL](https://www.postgresql.org/) as the data store.
The package contains database migrations, and an API to interact with database.

```
.
├── db
│   ├── migration
│   ├── mock
│   └── testdata
```

### deploy

The `deploy` directory contains all the essentials to setup Tinkerbell stack.
You can setup a local stack with `docker-compose` or Vagrant.

```
.
├── deploy
│   ├── db
│   ├── registry
│   ├── tls
│   └── vagrant
│   └── scripts
```

### grpc-server

The `grpc-server` exposes a gRPC API that connects everything together.
It has a base server that implements the API.

```
.
├── grpc-server
│   ├── grpc_server.go
│   ├── hardware.go
│   ├── hardware_test.go
│   ├── template.go
│   ├── template_test.go
│   ├── tinkerbell.go
│   ├── tinkerbell_test.go
│   ├── workflow.go
│   └── workflow_test.go
```

### protos

The `protos` package contains all the protobuf files used by the gRPC server.
Expand All @@ -189,15 +134,6 @@ CI will ensure generated files are up to date.

[buf]: https://buf.build/

```
.
├── protos
│   ├── hardware
│   ├── packet
│   ├── template
│   └── workflow
```

### environment variables

Tink Server, CLI, and Worker environment variables are documented [here](docs/ENVVARS.md).
Loading