-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update, simplify and remove redundant steps in CI config #657
Update, simplify and remove redundant steps in CI config #657
Conversation
chrisdoherty4
commented
Dec 23, 2022
•
edited
Loading
edited
- Update action version for every action
- Remove superfluous steps such as setting up QEMU
- Reference the same Go version throughout
c0d2b6d
to
6b6ad96
Compare
Codecov Report
@@ Coverage Diff @@
## main #657 +/- ##
=======================================
Coverage 50.45% 50.45%
=======================================
Files 20 20
Lines 995 995
=======================================
Hits 502 502
Misses 487 487
Partials 6 6 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
6b6ad96
to
eda07dc
Compare
if: ${{ startsWith(github.ref, 'refs/heads/main') }} | ||
with: | ||
registry: quay.io | ||
username: ${{ secrets.QUAY_USERNAME }} | ||
password: ${{ secrets.QUAY_PASSWORD }} | ||
- name: Set up QEMU | ||
uses: docker/setup-qemu-action@v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dont we need qemu for Docker multi-arch builds?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope. I think this is a relic of when multi-arch builds included binary compilation. The system now cross compiles the binaries in an earlier job. docker build
doesn't need QEMU to build arch specific images.
32d00ee
to
424a392
Compare
Signed-off-by: Chris Doherty <chris.doherty4@gmail.com>
424a392
to
fef491a
Compare
@mergify queue |
Sorry but this command cannot run when the configuration is updated |