Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update, simplify and remove redundant steps in CI config #657

Merged
merged 1 commit into from
Dec 23, 2022

Conversation

chrisdoherty4
Copy link
Member

@chrisdoherty4 chrisdoherty4 commented Dec 23, 2022

  • Update action version for every action
  • Remove superfluous steps such as setting up QEMU
  • Reference the same Go version throughout

@chrisdoherty4 chrisdoherty4 force-pushed the feat/simplify-ci branch 2 times, most recently from c0d2b6d to 6b6ad96 Compare December 23, 2022 20:37
@codecov
Copy link

codecov bot commented Dec 23, 2022

Codecov Report

Merging #657 (d71138b) into main (1186b49) will not change coverage.
The diff coverage is n/a.

❗ Current head d71138b differs from pull request most recent head fef491a. Consider uploading reports for the commit fef491a to get more accurate results

@@           Coverage Diff           @@
##             main     #657   +/-   ##
=======================================
  Coverage   50.45%   50.45%           
=======================================
  Files          20       20           
  Lines         995      995           
=======================================
  Hits          502      502           
  Misses        487      487           
  Partials        6        6           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@chrisdoherty4 chrisdoherty4 changed the title Simplify .github/workflows/ci.yml Update and simplify .github/workflows/ci.yml Dec 23, 2022
@chrisdoherty4 chrisdoherty4 changed the title Update and simplify .github/workflows/ci.yml Update, simplify and remove redundant steps in .github/workflows/ci.yml Dec 23, 2022
@chrisdoherty4 chrisdoherty4 changed the title Update, simplify and remove redundant steps in .github/workflows/ci.yml Update, simplify and remove redundant steps in CI config Dec 23, 2022
if: ${{ startsWith(github.ref, 'refs/heads/main') }}
with:
registry: quay.io
username: ${{ secrets.QUAY_USERNAME }}
password: ${{ secrets.QUAY_PASSWORD }}
- name: Set up QEMU
uses: docker/setup-qemu-action@v1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont we need qemu for Docker multi-arch builds?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope. I think this is a relic of when multi-arch builds included binary compilation. The system now cross compiles the binaries in an earlier job. docker build doesn't need QEMU to build arch specific images.

@chrisdoherty4 chrisdoherty4 force-pushed the feat/simplify-ci branch 5 times, most recently from 32d00ee to 424a392 Compare December 23, 2022 21:58
Signed-off-by: Chris Doherty <chris.doherty4@gmail.com>
@jacobweinstock jacobweinstock added the ready-to-merge Signal to Mergify to merge the PR. label Dec 23, 2022
@jacobweinstock
Copy link
Member

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented Dec 23, 2022

Sorry but this command cannot run when the configuration is updated

@jacobweinstock jacobweinstock merged commit b750ec8 into tinkerbell:main Dec 23, 2022
@chrisdoherty4 chrisdoherty4 deleted the feat/simplify-ci branch May 15, 2023 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants