-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up and rearrange packages #663
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #663 +/- ##
==========================================
+ Coverage 50.45% 50.96% +0.51%
==========================================
Files 20 19 -1
Lines 995 985 -10
==========================================
Hits 502 502
+ Misses 487 477 -10
Partials 6 6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
chrisdoherty4
force-pushed
the
feat/cleanup
branch
from
December 27, 2022 03:03
8ccc1d6
to
102b0d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, thanks @chrisdoherty4
chrisdoherty4
force-pushed
the
feat/cleanup
branch
from
December 27, 2022 14:00
102b0d7
to
1a3d2df
Compare
jacobweinstock
previously approved these changes
Dec 27, 2022
chrisdoherty4
force-pushed
the
feat/cleanup
branch
from
December 27, 2022 15:19
1a3d2df
to
5cfc076
Compare
- Remove TLS configurability - Move packages that can be easily moved and are internal to /internal - Update some package names to be more representative of their function - Remove obsolete/unused code Signed-off-by: Chris Doherty <chris.doherty4@gmail.com>
chrisdoherty4
force-pushed
the
feat/cleanup
branch
from
December 27, 2022 15:53
5cfc076
to
ff40cc6
Compare
jacobweinstock
approved these changes
Dec 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Execute on some general cleanup for unused/deprecated/obsolete functionality and rearrange packages.
Controllers contain code generation integration that needs to be reworked separately so as to avoid lots of churn on this PR.