Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up and rearrange packages #663

Merged
merged 1 commit into from
Dec 27, 2022
Merged

Conversation

chrisdoherty4
Copy link
Member

@chrisdoherty4 chrisdoherty4 commented Dec 27, 2022

Execute on some general cleanup for unused/deprecated/obsolete functionality and rearrange packages.

  • Remove TLS support in Tink Server
  • Remove Postgres configurability
  • Remove metrics package; it contained cache related metrics that were possibly related to the old cacher backend and didn't seem useful, everything else leftover didn't seem useful either
  • Move packages that can be easily moved and are internal to /internal
  • Update some package names to be more representative of their function
  • Remove obsolete/unused code

Controllers contain code generation integration that needs to be reworked separately so as to avoid lots of churn on this PR.

@codecov
Copy link

codecov bot commented Dec 27, 2022

Codecov Report

Merging #663 (ff40cc6) into main (1369125) will increase coverage by 0.51%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #663      +/-   ##
==========================================
+ Coverage   50.45%   50.96%   +0.51%     
==========================================
  Files          20       19       -1     
  Lines         995      985      -10     
==========================================
  Hits          502      502              
+ Misses        487      477      -10     
  Partials        6        6              
Impacted Files Coverage Δ
internal/convert/workflow.go 100.00% <ø> (ø)
internal/server/kubernetes_api.go 0.00% <ø> (ø)
internal/server/kubernetes_api_workflow.go 30.15% <ø> (ø)
internal/testtime/frozen_time.go 27.27% <ø> (ø)
internal/workflow/funcs.go 100.00% <ø> (ø)
internal/workflow/template_validator.go 95.34% <ø> (ø)
pkg/controllers/workflow/controller.go 79.31% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@jacobweinstock jacobweinstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks @chrisdoherty4

cmd/tink-worker/cmd/root.go Outdated Show resolved Hide resolved
jacobweinstock
jacobweinstock previously approved these changes Dec 27, 2022
- Remove TLS configurability
- Move packages that can be easily moved and are internal to /internal
- Update some package names to be more representative of their function
- Remove obsolete/unused code

Signed-off-by: Chris Doherty <chris.doherty4@gmail.com>
@jacobweinstock jacobweinstock added the ready-to-merge Signal to Mergify to merge the PR. label Dec 27, 2022
@mergify mergify bot merged commit d9f025f into tinkerbell:main Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants