Clean up shell.nix #726
Merged
Clean up shell.nix #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #726 +/- ##
=======================================
Coverage 55.54% 55.54%
=======================================
Files 26 26
Lines 1100 1100
=======================================
Hits 611 611
Misses 474 474
Partials 15 15 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| @@ -9,29 +9,11 @@ in { pkgs ? import (_pkgs.fetchFromGitHub { | |||
|
|
|||
| with pkgs; | |||
|
|
|||
| let | |||
There was a problem hiding this comment.
How does this work with the CI now?
There was a problem hiding this comment.
Dont know if I understand the questions, sorry. Currently, the shell.nix file is only needed for the ci-checks.sh script.
There was a problem hiding this comment.
That answers the question 👍🏻 ; I'd forgotten.
Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
jacobweinstock
force-pushed
the
clean-shell-nix
branch
from
f481df7 to
0e32177
Compare
chrisdoherty4
approved these changes
May 10, 2023
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 7be72c7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
clean up shell.nix file of unused/needed deps for CI.
Why is this needed
Fixes: #
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: