Fixes #38: Using persistent volume to hold registry data #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parauliya
changed the title
In this fix we are using "/var/tinkerbell/registry" directory locally to persist the data of registry
|
@parauliya Can you rebase the branch, please? |
Done. Branch Updated. |
|
This seems fine, though I don't like to assume we can grab a dir in /var. It would be nice to have support for a $PREFIX or similar so users can tailor where our files/dirs land. I'll open that up as a separate issue though. |
mmlb
approved these changes
Apr 24, 2020
nathangoulding
approved these changes
Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this fix we are using "/var/tinkerbell/registry" directory locally to persist the data of private registry we are creating to have worker and action images.