Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework build tool installation #877

Merged
merged 2 commits into from
Feb 5, 2024

Conversation

chrisdoherty4
Copy link
Member

Using go run has proven to be slower than installing tools. This PR changes all tools to be installed in out/tools and fixes unnecessary reinstallations.

Signed-off-by: Chris Doherty <chris.doherty4@gmail.com>
Copy link

codecov bot commented Feb 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (751e807) 51.23% compared to head (1fd90af) 51.23%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #877   +/-   ##
=======================================
  Coverage   51.23%   51.23%           
=======================================
  Files          33       33           
  Lines        1460     1460           
=======================================
  Hits          748      748           
  Misses        666      666           
  Partials       46       46           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jacobweinstock jacobweinstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too much Make! 😝

@chrisdoherty4
Copy link
Member Author

@mergify queue

Copy link
Contributor

mergify bot commented Feb 3, 2024

queue

🛑 The pull request has been removed from the queue default

The pull request #877 has been manually updated.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@chrisdoherty4
Copy link
Member Author

@mergify refresh

Copy link
Contributor

mergify bot commented Feb 5, 2024

refresh

✅ Pull request refreshed

@chrisdoherty4
Copy link
Member Author

@mergify queue

Copy link
Contributor

mergify bot commented Feb 5, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 83075f0

@mergify mergify bot merged commit 83075f0 into tinkerbell:main Feb 5, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants