Unify example notebooks, rerun example notebooks #1330
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Mr-Geekman
changed the title
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## docs-prototype #1330 +/- ##
=================================================
Coverage ? 89.10%
=================================================
Files ? 204
Lines ? 12643
Branches ? 0
=================================================
Hits ? 11265
Misses ? 1378
Partials ? 0 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
🚀 Deployed on https://deploy-preview-1330--etna-docs.netlify.app |
# Conflicts: # CHANGELOG.md
|
View / edit / reply to this conversation on ReviewNB alex-hse-repository commented on 2023-07-31T07:12:14Z Why don't just install it here? |
|
View / edit / reply to this conversation on ReviewNB alex-hse-repository commented on 2023-07-31T07:12:15Z Line #8. warnings.filterwarnings("ignore")
Lets place it in the beginning Mr-Geekman commented on 2023-07-31T07:23:30Z In the beginning we have
ts = TSDataset(df, freq="1M")
where we expect warning to happen. |
|
View / edit / reply to this conversation on ReviewNB alex-hse-repository commented on 2023-07-31T07:12:16Z ??? |
|
View / edit / reply to this conversation on ReviewNB alex-hse-repository commented on 2023-07-31T07:12:17Z We actually can start all the notebooks like this. May be we also need some kind of template for notebooks Mr-Geekman commented on 2023-07-31T07:25:19Z We don't add new notebooks every day to have a template for this.
|
|
View / edit / reply to this conversation on ReviewNB alex-hse-repository commented on 2023-07-31T07:12:20Z Why can't we just ignore all the warnings? |
|
View / edit / reply to this conversation on ReviewNB alex-hse-repository commented on 2023-07-31T07:12:20Z Why did you comment this line? Mr-Geekman commented on 2023-07-31T07:26:50Z Because it produced some output that I didn't want to show.
We can uncomment it, it isn't that necessary. |
|
View / edit / reply to this conversation on ReviewNB alex-hse-repository commented on 2023-07-31T07:12:22Z In the other notebooks it is not in this level Mr-Geekman commented on 2023-07-31T07:46:34Z It is very strange. It looks normal if you view it on github.
|
|
View / edit / reply to this conversation on ReviewNB alex-hse-repository commented on 2023-07-31T07:12:23Z *Note*?? |
|
View / edit / reply to this conversation on ReviewNB alex-hse-repository commented on 2023-07-31T07:12:24Z Why did you remove the header? Mr-Geekman commented on 2023-07-31T07:58:49Z I don't think it is necessary. It is a part of |
| @@ -4,37 +4,36 @@ | |||
| "cell_type": "markdown", | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Don't have any idea...
|
View / edit / reply to this conversation on ReviewNB alex-hse-repository commented on 2023-07-31T07:12:26Z Don't we want to have numeration everywhere? Mr-Geekman commented on 2023-07-31T08:02:03Z Will be fixed. |
|
View / edit / reply to this conversation on ReviewNB alex-hse-repository commented on 2023-07-31T07:12:27Z Why did the time change so much? Mr-Geekman commented on 2023-07-31T08:03:03Z Because it was running on a different machine. |
|
Better, but still looks a little bit weird |
|
Table of contents works only for the first level in the notebooks |
|
In the beginning we have
ts = TSDataset(df, freq="1M")
where we expect warning to happen. View entire conversation on ReviewNB |
|
We don't add new notebooks every day to have a template for this.
View entire conversation on ReviewNB |
|
Because it produced some output that I didn't want to show.
We can uncomment it, it isn't that necessary. View entire conversation on ReviewNB |
|
It is very strange. It looks normal if you view it on github.
View entire conversation on ReviewNB |
|
I don't think it is necessary. It is a part of View entire conversation on ReviewNB |
|
Will be fixed. View entire conversation on ReviewNB |
|
Because it was running on a different machine. View entire conversation on ReviewNB |
Before submitting (must do checklist)
Proposed Changes
Look #1328.
Closing issues
Closes #1328.