If the board doesn't report a firmata version, ask for it #17
Conversation
|
FYI, there's no test here because I'm not sure about what to do if the board doesn't report. Happy to add it once we come to a conclusion. |
|
Any update on this? Really need it to go in so I can get Bluetooth serial communications working. |
|
Hey @tino any updates on this? I really need this to go in and haven't heard anything from you... |
|
The solution sounds right to me, and we probably want to issue a warning if we dont get what we want. I'll probably be able to test and check this in this weekend. Sorry if I aint to quick to respond, it's a hobby project for me. On Sat, Sep 28, 2013 at 6:11 PM, Swift notifications@github.com wrote:
|
|
Cool. Keep me posted on anything you need from me. Totally understand it's a hobby project. Mine is too :) Just a friendly ping. If you ever need help maintaining, I'm more than happy to lend a hand. |
|
Ping. Any updates on this? I'd really like to get it in before Robots Conf (http://robotsconf.com/) |
|
Hey man, sorry to keep you waiting for so long. I've been pushing it from weekend to weekend (together with some other related issues on this repo), but still have a lot of other stuff to do. So please feel free to implement these changes yourself. |
|
I guess I waited that long that there are conflicts now. Anybody still interested in this fix? |
It's possible that the board doesn't report the firmata version before the
iterateloop in the init function ends (mostly in high latency situations like bluetooth serial). This fixes it by asking the board for a version and iterating until it receives it or until 5 seconds has elapsed.Only thing I wasn't sure on was wether or not to raise an exception if firmata version wasn't reported. What do you think?
Many thanks to @kymwatts to helping me discover this issue.