Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for adjusting to VS Code theme #120

Closed
mforkel opened this issue Aug 2, 2022 · 3 comments · Fixed by #123
Closed

Support for adjusting to VS Code theme #120

mforkel opened this issue Aug 2, 2022 · 3 comments · Fixed by #123
Labels
enhancement New feature or request

Comments

@mforkel
Copy link

mforkel commented Aug 2, 2022

I use Graphviz Interactive Preview to display dot graphs created by quilt graph. These graphs do not contain any color or font information. That results in black nodes and edges on a white background, which does not match well with most VS Code color themes.

Currently, I adapt the graph source with gvpr and a program file like

BEG_G {
    bgcolor="#1e1e1e"       // editor.background
}
N {
    color="#d4d4d4",        // editor.foreground
    fontcolor="#d4d4d4",    // editor.foreground
    fontname="Consolas",
    fontsize="14pt"
}
E {
    color="#d4d4d4",        // editor.foreground
    fontcolor="#d4d4d4",    // editor.foreground
    fontname="Consolas",
    fontsize="14pt"
}

That is not a real solution. The actual color values are not available to an extension or to the user, so they can't be provided programmatically or in the configuration. But color and font information is available through CSS variables in webviews.

Would it be possible to add an option for the display of graphs to change the default values for graph display to those of the current VS Code theme?

@bigbug
Copy link
Collaborator

bigbug commented Aug 2, 2022

That's something I already tried in . However, it needs some more polishing, which I canˋt do at the moment.

@bigbug bigbug added the enhancement New feature or request label Aug 2, 2022
@mforkel
Copy link
Author

mforkel commented Aug 4, 2022

Just discovered your own issue #72. Sorry I missed it. I guess that's what you're referring to in you reply ("tried in ")?

@bigbug
Copy link
Collaborator

bigbug commented Aug 6, 2022

Exactly. Unfortunately it currently looks like this if the nodes have the attribute "filled":
Screenshot 2022-08-06 at 20 54 03

@bigbug bigbug linked a pull request Aug 15, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants