Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internalise HTTP extensions (remove dependency on HTTPlease) #166

Open
tintoy opened this issue Dec 1, 2024 · 0 comments
Open

Internalise HTTP extensions (remove dependency on HTTPlease) #166

tintoy opened this issue Dec 1, 2024 · 0 comments
Assignees
Labels
breaking-change/binary Breaking change in binary compatibility; potential issue for upstream consumers if when upgrading.

Comments

@tintoy
Copy link
Owner

tintoy commented Dec 1, 2024

As discussed in #165, copy a minimum subset of functionality (e.g. URI templates, and consistent request/response handling) into dotnet-kube-client (e.g. in the KubeClient assembly under the KubeClient.Http namespace) to maintain source-level compatiblity (although not binary compatibility).

Where possible, use existing .NET extensions

Initial targeting should be for net6.0, net7.0, net8.0, net9.0.

Some initial notes

Possible (partial) replacement (of implementation) for HTTPlease URI-template functionality:

(note: these look impractical to consume, since the only way to get access to them would require a <FrameworkReference Include="Microsoft.AspNetCore.App" /> from the KubeClient project that uses them)

Alternative implementation (and one of the most popular) of URI templates:

https://github.com/tavis-software/Tavis.UriTemplates

@tintoy tintoy added the breaking-change/binary Breaking change in binary compatibility; potential issue for upstream consumers if when upgrading. label Dec 1, 2024
@tintoy tintoy self-assigned this Dec 1, 2024
@tintoy tintoy changed the title Remove dependency on HTTPlease Internalise HTTP extensions (remove dependency on HTTPlease) Dec 1, 2024
tintoy added a commit that referenced this issue Dec 24, 2024
(will be needed to modernise KubeClient's dependency injection to support Microsoft.Extensions.Http)

#166
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change/binary Breaking change in binary compatibility; potential issue for upstream consumers if when upgrading.
Projects
None yet
Development

No branches or pull requests

1 participant