Switch the BC dependency over to the official package #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi - thanks for contributing! I suspect that dependency was added before there was an official package but it would be much nicer to use the office one. We don’t currently have much in the way of test coverage for our usage of BouncyCastle so I’ll need to add a test or 2 just to make sure the core use-cases don’t break 🙂 (hopefully sometime tonight) |
tintoy
added a commit
that referenced
this pull request
Aug 6, 2024
tintoy
added a commit
that referenced
this pull request
Aug 7, 2024
tintoy
added a commit
that referenced
this pull request
Aug 7, 2024
|
Thanks - it's merged and the tests pass :) |
tintoy
added a commit
that referenced
this pull request
Aug 7, 2024
|
Published |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BouncyCastle has their own official nuget package - any reason we shouldn't switch over?
https://www.nuget.org/packages/BouncyCastle.Cryptography