Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced functionally for Central Package Management (ie PackageVersion) #93

Open
3 tasks
tintoy opened this issue Jan 12, 2024 · 0 comments
Open
3 tasks

Comments

@tintoy
Copy link
Owner

tintoy commented Jan 12, 2024

Some enhancements to the work started in #84:

  • Only offer PackageVersion element completion if the MSBuild project's ManagePackageVersionsCentrally property is set to true (or True).
  • Consider also hiding Version attribute completion on PackageReference elements if ManagePackageVersionsCentrally is set (might want to make this configurable though, if we choose to do it at all).
  • Rename HandlePackageReferenceElementCompletion and HandlePackageReferenceAttributeCompletion to HandleElementCompletion and HandleAttributeCompletion since the handler now deals with multiple item types.
@tintoy tintoy self-assigned this Jan 12, 2024
tintoy added a commit that referenced this issue Jan 14, 2024
- Don't offer PackageVersion element as a completion unless the project's ManagePackageVersionsCentrally property is set to "true".
- Refactor PackageReferenceCompletionProvider to do a better job of documenting its semantics
- Move MSBuildHelper and related types and constants into their own namespace.
- Create constants for well-known item elements and attributes.

#93
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant