Validate dotnet process exit code when discovering .NET SDK / runtime info #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dly names in error messages tintoy/msbuild-project-tools-vscode#156
… resolve a matching runtime or SDK for global.json tintoy/msbuild-project-tools-vscode#156
- Rename TaskScannerTests.RuntimeInfo to TaskScannerTests.CurrentDotnetInfo
DoctorKrolic
reviewed
Aug 9, 2024
|
Haven’t forgotten about this, BTW - work is just a little hectic at the moment. Should have it done in a day or 2! |
- Don't use hex notation for dotnet host exit codes - Use <inheritdoc /> for exception constructors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve behaviour of .NET version detection when the .NET host cannot resolve a matching runtime or SDK for
global.json.The
dotnethost has many known exit codes, but currently only a couple are currently of interest to us. I have nevertheless included all known exit codes in an enum since the exit-code names (rather than just hex numbers) are quite likely to aid future troubleshooting efforts.,This PR only partially addresses tintoy/msbuild-project-tools-vscode#156 (the language server side), although, since VSCode's language client doesn't provide access to the process exit code, it's challenging (for the extension side) to reliably return user-facing error messages from the language server (in scenarios like this that occur before the LSP connection has been established).
We might want to consider changing our STDERR output, at some point, be JSON format so the extension has a better chance of interpreting it.