Skip to content
This repository has been archived by the owner on Jun 15, 2023. It is now read-only.

Commit

Permalink
Make EDID conform with edid-decode checks (#108)
Browse files Browse the repository at this point in the history
Our previous EDIDs failed to conform with `edid-decode`'s `--check`
flag.
This updated EDID has a number of modifications to make it conform with
the
tests - fixing the warnings and failed attributes.

Warnings fixed:

IT Video formats are now underscanned by default.

There are no longer multiple native progressive timings defined.

Failures fixed:

Detailed Timing Descriptor 1 no longer lists an image size.
Detailed Timing Descriptor 2 no longer lists an image size.

Display Range Limits now sets the correct bytes: Byte 11 is 0x00 and
Bytes 12-17 are now 0x20.

There are no longer more Native Detailed Timing Descriptors than
Detailed Timing Descriptors.

Removed duplicate video data definition (VIC 60)

Adjusted monitor ranges to 24-90 Hz (Vertical Freq) and 18-80 kHz 
(Horizontal Freq)
<a data-ca-tag
href="https://codeapprove.com/pr/tiny-pilot/ansible-role-ustreamer/108"><img
src="https://codeapprove.com/external/github-tag-allbg.png" alt="Review
on CodeApprove" /></a>
  • Loading branch information
db39 authored May 12, 2023
1 parent 3d88801 commit b1017f8
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 8 deletions.
24 changes: 17 additions & 7 deletions defaults/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -55,29 +55,39 @@ ustreamer_capture_device: null

# To create a new EDID:
# 1. Convert the existing EDID to binary using "edid2bin".
# 2. Edit the binary using "AW EDID Editor".
# 2. Edit the binary using "AW EDID Editor v.02.00.13".
# 3. Save the new EDID in binary format.
# 4. Convert the binary EDID to a hex EDID using "make-edid".
# - Use the "--yaml" option if required.

# Note: You may need to perform a few extra steps in order for the EDID
# to conform to edid-decode's check - but only if the "Display Range Limits"
# block changes. This is due to a bug in AW EDID Editor v.02.00.13 that doesn't
# set the correct bytes.
# To work around this:
# 1. Open the new EDID in "AW EDID Editor v.3.0.10".
# 2. Save the EDID to set correct bytes in the "Display Range Limits" block
# 3. Re-open the EDID in "AW EDID Editor v.02.00.13" and re-set
# the screen size dimensions to 0 (both vertical and horizontal)

# EDID for TC358743 chip.
ustreamer_edid: |
00ffffffffffff005262769800888888
2d1e0103800000781aee91a3544c9926
0f50547fef8081c08140810081809500
a9c081406140271f80f07138164038c0
350040442100001eec2c80a070381a40
3020350040442100001e000000fc0054
350000000000001eec2c80a070381a40
3020350000000000001e000000fc0054
696e7950696c6f740a202020000000fd
003b3d0f2e1000000000000000000149
02031f734c010204139f2021223c3d3e
3c2309070766030c00300080e2007f00
00185a125010000a20202020202001aa
02031ef14b010204131f2021223c3d3e
2309070766030c00300080e2007f0000
00000000000000000000000000000000
00000000000000000000000000000000
00000000000000000000000000000000
00000000000000000000000000000000
00000000000000000000000000000000
0000000000000000000000000000004e
0000000000000000000000000000008e

# Location to store EDID files.
ustreamer_edids_dir: /home/{{ ustreamer_user }}/edids
Expand Down
2 changes: 1 addition & 1 deletion tests/decode-edid
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,4 @@ grep "ustreamer_edid:" -A16 defaults/main.yml | \
tail --lines=+2 | \
`# Strip whitespace` \
tr --delete "[:blank:]" | \
edid-decode
edid-decode --check

0 comments on commit b1017f8

Please sign in to comment.