This repository has been archived by the owner on Jun 15, 2023. It is now read-only.
Install the uStreamer Debian package instead of building from source #100
Assignees
Labels
Comments
This was referenced May 18, 2023
jdeanwallace
added a commit
that referenced
this issue
May 24, 2023
Related #100 This PR only builds uStreamer from source if a uStreamer Debian package is not provided. This will allow TinyPilot to specify a uStreamer Debian package and avoid building uStreamer from source on every install/update. I've [tested these changes in CI](https://app.circleci.com/pipelines/github/tiny-pilot/ansible-role-ustreamer/371/workflows/f85d89d6-bf24-40e7-868b-692299e6c38e/jobs/962?invite=true#step-104-396) via 179fe04. I've also tested these changes on device via a [scratch TinyPilot Pro PR](tiny-pilot/tinypilot-pro#908). <a data-ca-tag href="https://codeapprove.com/pr/tiny-pilot/ansible-role-ustreamer/110"><img src="https://codeapprove.com/external/github-tag-allbg.png" alt="Review on CodeApprove" /></a>
|
I've cut https://github.com/tiny-pilot/ansible-role-ustreamer/releases/tag/1.4.0 so this should be unblocked now. |
jdeanwallace
added a commit
to tiny-pilot/tinypilot
that referenced
this issue
May 26, 2023
…1408) Resolves tiny-pilot/ansible-role-ustreamer#100 This PR specifies the URL to our [uStreamer Debian package release](https://github.com/tiny-pilot/ustreamer-debian/releases/tag/ustreamer_5.38-20230525134432) (via the `ustreamer_debian_package_path` variable) and avoids unnecessarily specifying uStreamer git variables (i.e., `ustreamer_repo` and `ustreamer_repo_version `) in the TinyPilot Ansible role. Notes: * By default our Ansible role will install uStreamer for `armhf` architecture. However, to test the Ansible role in CI, we needed to [override the `ustreamer_debian_package_path` value to point to uStreamer for `amd64` architecture](https://github.com/tiny-pilot/tinypilot/pull/1408/files#diff-a820d54bd8941675036b81b0e7d1b08afee2821c526e5806ab6c8482ec0880d4R24-R29). I've tested this build on device. <a data-ca-tag href="https://codeapprove.com/pr/tiny-pilot/tinypilot/1408"><img src="https://codeapprove.com/external/github-tag-allbg.png" alt="Review on CodeApprove" /></a>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Related tiny-pilot/tinypilot#1353
Blocked on tiny-pilot/ustreamer-debian#4
Requirements
Grab the uStreamer Debian package path from a
ustreamer-debianreleaseMaintain building from source if the Debian package is not specified
The text was updated successfully, but these errors were encountered: