Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override dark-mode in style guide #1257

Merged
merged 1 commit into from
Jan 12, 2023
Merged

Conversation

jotaen4tinypilot
Copy link
Contributor

@jotaen4tinypilot jotaen4tinypilot commented Jan 11, 2023

With dark-mode turned on, the style guide is not really useable. The easiest is to override (and thus ignore) dark-mode in the style guide and force it to be light-mode. Otherwise, we would have to adjust the default text color, plus several background and border colors, to make all elements work with the dark background.

Screenshot 2023-01-11 at 17 34 16

Review on CodeApprove

Copy link
Contributor

@jdeanwallace jdeanwallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated comment from CodeApprove ➜

Approved on CodeApprove
✔️ Approved

Yes, I agree that this is the best option for now. Only once we decide to make dark-mode color adjustments to the pop-up dialogs, then this hack can be removed:

Screen Shot 2023-01-12 at 11.36.41.png

LGTM!


👀 @jotaen4tinypilot it's your turn please take a look

@jotaen4tinypilot
Copy link
Contributor Author

Only once we decide to make dark-mode color adjustments to the pop-up dialogs, then this hack can be removed:

Historical note on that, for curiosity: when implementing the dark mode originally, I already explored the option of a dark-mode dialog panel. I found it not to be feasible, however, because if the dialog panel itself is dark, then the black-ish overlay layer in the background must be inverted, i.e. bright. It might be possible to make the background overlay layer look grey-ish, but I think it might be difficult to get that right, and find a good balance between “mostly dark overall” but still “high-enough contrast between dialog panel and background”.

@jotaen4tinypilot jotaen4tinypilot merged commit 3471ffa into master Jan 12, 2023
@jotaen4tinypilot jotaen4tinypilot deleted the styleguide-nodark branch January 12, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants