Improve temperature lines in TinyPilot logs #1542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automated comment from CodeApprove ➜👀 @cghague it's your turn, please take a look |
Automated comment from CodeApprove ➜⏳ @jdeanwallace please review this Pull Request |
jdeanwallace
previously requested changes
Aug 2, 2023
There was a problem hiding this comment.
Automated comment from CodeApprove ➜
⏳ Approval Pending (1 unresolved comments)
Approval will be granted automatically when all comments are resolved
LGTM, thanks!
In: debian-pkg/opt/tinypilot-privileged/scripts/collect-debug-logs:
> Line 135
vcgencmd measure_temp | sed "s/temp=/CPU Temperature: /g"
Seeing as we don't need variable interpolation, can we use single quotes instead of double quotes?
👀 @cghague it's your turn please take a look
cghague
commented
Aug 9, 2023
There was a problem hiding this comment.
Automated comment from CodeApprove ➜
In: debian-pkg/opt/tinypilot-privileged/scripts/collect-debug-logs:
Resolved
jdeanwallace
approved these changes
Aug 9, 2023
There was a problem hiding this comment.
Automated comment from CodeApprove ➜
Approved: I have approved this change on CodeApprove and all of my comments have been resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1488
Runs a simple text replacement to make the output of
vcgencmd measure_tempmore readable.