Disable parallel e2e test execution locally #1695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtlynch
approved these changes
Nov 30, 2023
There was a problem hiding this comment.
Automated comment from CodeApprove ➜
✔️ Approved
Ah, I misunderstood fullyParallel and thought this was already the behavior.
LGTM, thanks!
👀 @jotaen4tinypilot it's your turn please take a look
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until we have addressed #1694, I’d suggest to disable parallel e2e test execution locally, otherwise there can be erratic failures in Pro (due to the security tests interfering with other tests).
On my local machine, this changes e2e execution speed from ~20s to ~26s. On CI, it obviously doesn’t change.
