Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditionally load EDID on device with TC358743 capture chip #1730

Merged
merged 2 commits into from
Jan 31, 2024

Conversation

jdeanwallace
Copy link
Contributor

@jdeanwallace jdeanwallace commented Jan 28, 2024

Resolves #1726

This PR only starts the load-tc358743-edid.service when a TC358743 capture chip is installed. This change avoids reporting the service as "failed" when a TC358743 capture chip is not installed on the device.

Caveat: The load-tc358743-edid.service process is still marked as (code=exited, status=1/FAILURE), but it's active state is no longer failed (Result: exit-code). Instead, its active state is inactive (dead) (Result: exec-condition).

Example output of service being skipped:

Jan 28 18:41:02 raspberrypi systemd[1]: Starting Load EDID for TC358743 HDMI capture chip....
Jan 28 18:41:02 raspberrypi systemd[1]: load-tc358743-edid.service: Control process exited, code=exited, status=1/FAILURE
Jan 28 18:41:02 raspberrypi systemd[1]: load-tc358743-edid.service: Skipped due to 'exec-condition'.
Jan 28 18:41:02 raspberrypi systemd[1]: Condition check resulted in Load EDID for TC358743 HDMI capture chip. being skipped.

Review on CodeApprove

@jdeanwallace jdeanwallace changed the title Conditionally start load-tc358743-edid service on device with TC358743 capture chip Conditionally load EDID on device with TC358743 capture chip Jan 28, 2024
@jdeanwallace jdeanwallace marked this pull request as ready for review January 28, 2024 19:12
Copy link
Contributor Author

Automated comment from CodeApprove ➜

@db39 please review this Pull Request

Copy link
Contributor

@db39 db39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated comment from CodeApprove ➜

Approved on CodeApprove
✔️ Approved

LGTM, thanks! Having the service inactive (instead of failed) by default definitely helps!


👀 @jdeanwallace it's your turn please take a look

@jdeanwallace jdeanwallace merged commit 545aa08 into master Jan 31, 2024
13 checks passed
@jdeanwallace jdeanwallace deleted the load-tc358743-edid branch January 31, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to load EDID with HDMI to USB capture device
2 participants