Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reconnect connect/disconnect handlers for HCI, Linux, and Windows Centrals #319

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

deadprogram
Copy link
Member

This PR is to reconnect connect/disconnect handlers for HCI, Linux, and Windows Centrals.

As mentioned in several different issues, somehow they got disconnected along the way.

@deadprogram
Copy link
Member Author

This will close #256 and #290 and #145

@deadprogram
Copy link
Member Author

UPDATE: added anther commit that also implements the connect handler for Peripherals, but only for HCI.

@deadprogram deadprogram force-pushed the reconnect-connect-handlers branch from 1705ad7 to 0f637e3 Compare January 4, 2025 16:43
…s centrals

Signed-off-by: deadprogram <ron@hybridgroup.com>
Signed-off-by: deadprogram <ron@hybridgroup.com>
@deadprogram deadprogram force-pushed the reconnect-connect-handlers branch from 0f637e3 to 5b7f3c4 Compare January 5, 2025 09:19
@deadprogram
Copy link
Member Author

Rebased against latest dev this PR is ready for review, please.

hci.go Show resolved Hide resolved
gap_hci.go Show resolved Hide resolved
Copy link
Contributor

@ysoldak ysoldak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a little nit about magic number that can be ignored.

@deadprogram
Copy link
Member Author

Thanks for review and feedback @ysoldak now merging.

@deadprogram deadprogram merged commit 62565e6 into dev Jan 9, 2025
4 checks passed
@deadprogram deadprogram deleted the reconnect-connect-handlers branch January 9, 2025 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants