feat(gap): add ConnectWithContext in gap_darwin.go #387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acouvreur
commented
Oct 4, 2025
| a.cm.CancelConnect(prphs[0]) | ||
|
|
||
| // record an error to use when the disconnect comes through later. | ||
| connectionError = ctx.Err() |
There was a problem hiding this comment.
This only difference is the error retrieval, here. Maybe we can find a "clever" way to not duplicate code.
…hContext WriteWithContext and ReadWithContext Related tinygo-org#339
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've just done these changes for
darwinbecause I am working on MacOS.I can implement it for
windowsandlinuxif this change is accepted.I can also work in adding context in different apis, such asDiscoverServices,DiscoverCharacteristicsandScan.I've added the context implementation for
DiscoverServicesWithContextDiscoverCharacteristicsWithContextWriteWithContextandReadWithContextin 434206bRelated #339