Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GC9A01 Driver #452

Merged
merged 3 commits into from
Sep 18, 2022
Merged

Add GC9A01 Driver #452

merged 3 commits into from
Sep 18, 2022

Conversation

lmatte7
Copy link
Contributor

@lmatte7 lmatte7 commented Aug 27, 2022

This PR adds driver support for the Waveshare 1.28in circular display. A lot of the code was based on the driver code for ST7735 with specific updates for this board. The full datasheet is available here.

The driver has been tested and can successfully run the display with a RPI Pico and a ESP32.

@deadprogram
Copy link
Member

Any comments @sago35 or @conejoninja before merging?

Copy link
Member

@sago35 sago35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lmatte7
For the most part, I think it is very good.
I commented because I would like to make the same design as other drivers.

Please update README.md.
Add a test to smoke-test in the Makefile.

If possible, please keep the interface in the same form as the st7735 and ili9341 interfaces.
In other words, we want int16 to be used instead of int32 in many places.
https://github.com/tinygo-org/drivers/blob/release/st7735/st7735.go
https://github.com/tinygo-org/drivers/blob/v0.22.0/ili9341/ili9341.go

gc9a01/gc9a01.go Outdated Show resolved Hide resolved
gc9a01/gc9a01.go Outdated Show resolved Hide resolved
gc9a01/gc9a01.go Outdated Show resolved Hide resolved
@lmatte7
Copy link
Contributor Author

lmatte7 commented Sep 6, 2022

@sago35 Thanks for the feedback! I’ll make the changes and send an update.

@lmatte7 lmatte7 requested a review from sago35 September 10, 2022 15:08
@sago35
Copy link
Member

sago35 commented Sep 13, 2022

I will review it tomorrow or so.

Copy link
Member

@sago35 sago35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lmatte7
Please add sleep to examples.
I will approve if you add it.

examples/gc9a01/main.go Show resolved Hide resolved
@lmatte7 lmatte7 requested a review from sago35 September 17, 2022 15:34
Copy link
Member

@sago35 sago35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you!

@deadprogram
Copy link
Member

Now going to squash/merge thank you for working on this @lmatte7

@deadprogram deadprogram merged commit 4061adf into tinygo-org:dev Sep 18, 2022
@lmatte7 lmatte7 mentioned this pull request Oct 2, 2022
deadprogram pushed a commit that referenced this pull request Dec 23, 2022
* Added driver for gc9a01 round display and example code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants