-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GC9A01 Driver #452
Add GC9A01 Driver #452
Conversation
Any comments @sago35 or @conejoninja before merging? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lmatte7
For the most part, I think it is very good.
I commented because I would like to make the same design as other drivers.
Please update README.md.
Add a test to smoke-test in the Makefile.
If possible, please keep the interface in the same form as the st7735 and ili9341 interfaces.
In other words, we want int16 to be used instead of int32 in many places.
https://github.com/tinygo-org/drivers/blob/release/st7735/st7735.go
https://github.com/tinygo-org/drivers/blob/v0.22.0/ili9341/ili9341.go
@sago35 Thanks for the feedback! I’ll make the changes and send an update. |
…dded smoketest for gc9a01
I will review it tomorrow or so. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lmatte7
Please add sleep to examples.
I will approve if you add it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you!
Now going to squash/merge thank you for working on this @lmatte7 |
* Added driver for gc9a01 round display and example code
This PR adds driver support for the Waveshare 1.28in circular display. A lot of the code was based on the driver code for ST7735 with specific updates for this board. The full datasheet is available here.
The driver has been tested and can successfully run the display with a RPI Pico and a ESP32.