added support for SK6812 to WS2812 device #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
SoftTacos
commented
Oct 14, 2023
ws2812/ws2812.go
Outdated
Comment on lines
17
to
20
| const ( | ||
| WS2812 DeviceType = iota // RGB | ||
| SK6812 // RGBA / RGBW | ||
| ) |
There was a problem hiding this comment.
If we would rather opt for making an entirely separate SK6812 device and leverage the same calls that Deivce.WriteByte uses, I'm happy to do that too.
|
Probably creating specific constructors vs. modifying the current one would be a better approach. // deprecated, use NewWS2812 or NewSK6812 depending on which device you want.
// calls NewWS2812() to avoid breaking everyone's existing code.
func New(pin machine.Pin) Device
// returns WS2812
func NewWS2812(pin machine.Pin) Device
// returns SK6812
func NewSK6812(pin machine.Pin) Device |
|
Love it, I'll get that changed soon. |
|
Thanks for working on this @SoftTacos now squash/merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for SK6812 (RGBA) LEDs to WS2812 device.
PR for issue: #608