Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use architecture-specific version of math.h #4

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

aykevl
Copy link
Member

@aykevl aykevl commented Mar 3, 2024

See: #2 (comment)

@QuLogic can you take a look?

@aykevl aykevl force-pushed the arm-math branch 5 times, most recently from 2f5397b to fe989ba Compare March 3, 2024 19:49
aykevl added 2 commits March 3, 2024 20:50
Apparently there were some updates which meant that there wasn't a
default LLVM version installed anymore?
It looks like math.h is the _only_ file that is architecture specific,
and apparently I missed it while adding ARM support.
@aykevl
Copy link
Member Author

aykevl commented Mar 3, 2024

Also fixed a CI issue.

aykevl added a commit to tinygo-org/tinygo that referenced this pull request Mar 3, 2024
They should, but we weren't testing this.
I discovered this while working on
tinygo-org/macos-minimal-sdk#4 which will likely
make math.h not work anymore. So I wanted to make sure we have a test in
place before we update that dependency.
aykevl added a commit to tinygo-org/tinygo that referenced this pull request May 25, 2024
They should, but we weren't testing this.
I discovered this while working on
tinygo-org/macos-minimal-sdk#4 which will likely
make math.h not work anymore. So I wanted to make sure we have a test in
place before we update that dependency.
deadprogram pushed a commit to tinygo-org/tinygo that referenced this pull request May 29, 2024
They should, but we weren't testing this.
I discovered this while working on
tinygo-org/macos-minimal-sdk#4 which will likely
make math.h not work anymore. So I wanted to make sure we have a test in
place before we update that dependency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant