Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: Update docsy 0.6, correct sidebar link #358

Merged
merged 2 commits into from
May 19, 2023
Merged

Conversation

deadprogram
Copy link
Member

This PR updates the Docsy theme to the latest released version v0.6.0

It also corrects the sidebar links for "edit page" so that they point to the correct location. See google/docsy#1420 (comment)

Signed-off-by: deadprogram <ron@hybridgroup.com>
Signed-off-by: deadprogram <ron@hybridgroup.com>
@deadprogram deadprogram added this to the v0.28.0 milestone May 18, 2023
Copy link
Member

@aykevl aykevl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Does this have a practical benefit, besides staying up to date?

@deadprogram
Copy link
Member Author

A few things appear to be simplified, and it is using the latest fontawesome. Nothing really obvious other than if you download the latest hugo and use this latest docksy everything runs as you expect without extra warnings.

@deadprogram
Copy link
Member Author

Thanks for review @aykevl now merging.

@deadprogram deadprogram merged commit 07d6c61 into dev May 19, 2023
@deadprogram deadprogram deleted the update-docsy-0.6 branch May 19, 2023 13:54
Copy link
Member

aykevl commented May 19, 2023

if you download the latest hugo and use this latest docksy everything runs as you expect without extra warnings.

Sounds like a good improvement then :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants