machine: add DMA support to spi tx #1176
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
941ea4e28b4c5cdfe877ef299cecbb2d3552f851
|
I think we'll always want to use DMA. That is an easier to use API and likely faster overall. |
|
I'm going to try and make it. |
|
I plan to switch to the method used in the following PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made the call to SetupDMA() to use DMA to send.
If no call is made, send it without DMA.
At the moment, it is wioterminal-only and most of the possible values cannot be set.
The source code is messy and not clean.
However, I think the future of effective use of the DMA can be examined on the basis of this PR.