Skip to content

Added support for MKR1000 board #1511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 2, 2020
Merged

Added support for MKR1000 board #1511

merged 3 commits into from
Dec 2, 2020

Conversation

fleshin
Copy link
Contributor

@fleshin fleshin commented Nov 25, 2020

Hi,
I am able to flash blinky1.go to MKR1000 and MKR1010 with this code. It is based on the nano-iot33 code.

@aykevl aykevl changed the base branch from release to dev November 26, 2020 14:25
Copy link
Member

@aykevl aykevl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Just one comment regarding a recent change.

@fleshin
Copy link
Contributor Author

fleshin commented Nov 26, 2020

Thanks! Used the 0.15 as the base, sorry about that. Your change was applied.

@aykevl
Copy link
Member

aykevl commented Dec 1, 2020

Can you perhaps rebase on the dev branch? There are some CI failures that should be fixed after rebasing, see #1497 for details.

@fleshin
Copy link
Contributor Author

fleshin commented Dec 2, 2020

I think this worked. All the checks passed.

@aykevl aykevl merged commit 7abc671 into tinygo-org:dev Dec 2, 2020
@aykevl
Copy link
Member

aykevl commented Dec 2, 2020

Thank you! I have merged this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants