Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker: add picolibc-include directory #2206

Merged
merged 1 commit into from
Oct 27, 2021
Merged

Docker: add picolibc-include directory #2206

merged 1 commit into from
Oct 27, 2021

Conversation

ysoldak
Copy link
Contributor

@ysoldak ysoldak commented Oct 26, 2021 •
edited
Loading

Fixes #2205

Verified locally by building docker image and running make smoke-test in tinygo-drivers.

aykevl
aykevl reviewed Oct 26, 2021
View reviewed changes
Dockerfile Show resolved Hide resolved
@aykevl
Copy link
Member

aykevl commented Oct 26, 2021

(Sidenote: #2110 will actually remove ./lib/picolibc-include/)

@ysoldak
Copy link
Contributor Author

ysoldak commented Oct 27, 2021

@aykevl you plan to merge #2110 first so this PR is obsolete or we merge this to unblock drivers?

@deadprogram deadprogram merged commit c8719f8 into tinygo-org:dev Oct 27, 2021
@ysoldak ysoldak deleted the fix-picolibc-include branch October 27, 2021 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aykevl aykevl aykevl left review comments

@deadprogram deadprogram deadprogram left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ysoldak @aykevl @deadprogram