-
Notifications
You must be signed in to change notification settings - Fork 911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add net.Buffers #2314
Add net.Buffers #2314
Conversation
Should fix mailru/easyjson#335, for the most part.
For completion, if we try to build or run the code in the linked issue under macos we get:
This builds and runs fine under wasi, and at least builds in other platforms. |
This is because of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Are there net.Buffers tests from stdlib that should be moved over too?
@dgryski there are some we can use. I will update this PR tomorrow. |
@fgsch will you add the tests you mentioned to this PR? 😸 |
@deadprogram Yeah, sorry. Been afk the last couple of days. I will get this done today. |
c61816f
to
8ca2343
Compare
@deadprogram tests added. |
8ca2343
to
6b711bf
Compare
Should fix the remaining problem from mailru/easyjson#335, for the most part.