os: port os.Rename + tests from upstream #2481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skip part of the test on Windows because of tinygo-org#2480 TODO: fix 2480 and unskip test TODO: pull in rest of upstream tests, fix problems they find Requested in tinygo-org#2109
dkegel-fastly
force-pushed
the
dkegel-os-add-rename
branch
from
6b9aa00
to
842fff9
Compare
dgryski
approved these changes
Jan 11, 2022
|
Thank you @dkegel-fastly and @dgryski now merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skips a couple fancy checks for now.
Skips part of the test on Windows because of #2480
TODO: fix 2480 and unskip test
TODO: pull in rest of upstream tests, fix problems they find
Requested in #2109