arm: Explicitly disable unwind tables #2482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
force-pushed
the
arm-no-unwind
branch
from
79ef75f
to
03006a3
Compare
|
That's probably okay. This PR currently only minimally affects arm builds where that option would have been disabled by default on Debian, and that PR would have had to explicitly enable it to use (but it doesn't, so I'll assume that arm is not yet a supported platform or it doesn't need unwind tables.) |
|
I don't know why LLVM needs to rebuild, and times out, for this PR but not others. |
|
@QuLogic you should rebase against |
Some clang builds (e.g., Fedora's) enable unwind tables by default. As tinygo does not need nor support them, that leads to undefined symbols when linking.
QuLogic
force-pushed
the
arm-no-unwind
branch
from
03006a3
to
6842586
Compare
|
Oops, thought I did, but it must have been before pulling. |
|
Thanks @QuLogic now merging. |
aykevl
reviewed
Jan 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some clang builds (e.g., Fedora's) enable unwind tables by default. As tinygo does not need nor support them, that leads to undefined symbols when linking.
Fixes #2477