Enable wasm pointer tracking for gc=none. #3280
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3278
This takes the simpler approach of allowing wasm pointer tracking on the stack to be enabled even with
gc=none
. none is documented as being useful for combining with a separate garbage collector. However in practice, it is basically impossible to do this with wasm because tracking pointers on the stack is required for any GC to be able to see them to mark them.It seems reasonable to enable the stack tracking code even when not using the TinyGo GC. Either a) an external GC is being used and the tracking is required or b) an external GC is not being used meaning there are no allocations, and therefore no tracking will actually happen.
Having the ability to swap in a custom GC allows TinyGo compiled wasm to perform quite well with low pause times, so this is very enabling for projects like coraza-proxy-wasm