-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: set correct workerId
in runtime: 'child_process'
#81
Conversation
I couldn't think of a better way to test the correct |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks! Impressive how fast you were able to set up a PR. 🚀
@Aslemammad this PR can be considered as semver patch. The process.__tinypool_state__.workerId
was always supposed to be Tinypool's workerId
and not the process.id
as it was set.
workerId
in runtime: 'child_process'
@AriPerkkio @alisd23 Thank you so much for the effort folks! |
Thanks both for the help and getting this through so quick! 👍 |
Final thing, @Aslemammad when can we expect a release? Looks like releases are done manually is that right? |
Yea sure, I'm just going to give an access to @AriPerkkio so he can releases. |
Thanks! 🙌 I'll do release tomorrow and do some testing with Vitest. |
First attempt at using the correct
threadId
/workerId
for the worker when inchild_process
mode.process.env
process.__tinypool_state__.workerId
from the env variable