Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DynamicPolicy should continue existing file #251

Merged
merged 3 commits into from
Apr 21, 2022

Conversation

simon04
Copy link
Contributor

@simon04 simon04 commented Apr 20, 2022

When a job is run every minute, the log file should contain more than just the logs of the last execution.

Description

Linked issue: #230

Definition of Done

  • I read contributing.md
  • There are no TODOs left in the code
  • Code style follows the tinylog standard
  • All classes and methods have Javadoc
  • Changes are covered by JUnit tests including edge cases, errors, and exception handling
  • Maven build works including compiling, tests, and checks (mvn verify)
  • Changes are committed by a verified email address that is assigned to the GitHub account (https://github.com/settings/emails)

Documentation

Agreements

  • I agree that my changes will be published under the terms of the Apache License 2.0 (mandatory)
  • I agree that my GitHub user name will be published in the release notes (optional)

When a job is run every minute, the log file should contain more than just the logs of the last execution.
@pmwmedia
Copy link
Member

Could you fix the failing JUnit test?

@pmwmedia pmwmedia self-requested a review April 20, 2022 21:53
@codecov
Copy link

codecov bot commented Apr 21, 2022

Codecov Report

Merging #251 (ebf38b0) into v2.5 (ed4c06d) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               v2.5     #251   +/-   ##
=========================================
  Coverage     94.42%   94.42%           
+ Complexity     2758     2757    -1     
=========================================
  Files           139      139           
  Lines          5292     5292           
  Branches        703      703           
=========================================
  Hits           4997     4997           
  Misses          164      164           
  Partials        131      131           
Impacted Files Coverage Δ
.../main/java/org/tinylog/policies/DynamicPolicy.java 83.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed4c06d...ebf38b0. Read the comment docs.

@pmwmedia
Copy link
Member

Thank you for fixing the JUnit test. Can you adjust the method name and the Javadoc of the test method, too?

@pmwmedia pmwmedia merged commit 5622635 into tinylog-org:v2.5 Apr 21, 2022
@pmwmedia
Copy link
Member

Thank you very much :)

@pmwmedia pmwmedia added this to the 2.5 milestone Apr 21, 2022
@pmwmedia pmwmedia removed their request for review April 21, 2022 08:43
@github-actions
Copy link

github-actions bot commented Oct 9, 2022

This closed pull request has been locked automatically. However, please feel free to file an issue or create a new pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants