Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Substitute with isNullOrEmpty() call #678

Merged
merged 1 commit into from
Feb 11, 2024
Merged

Conversation

FourteenBrush
Copy link
Contributor

Description

Linked issue:

none

Linked website pull request, if the documention of https://tinylog.org/v2/ has to be updated:

none

Definition of Done

  • I read contributing.md
  • There are no TODOs left in the code
  • Code style follows the tinylog standard
  • All classes and methods have Javadoc
  • Changes are covered by JUnit tests including edge cases, errors, and exception handling
  • Maven build works including compiling, tests, and checks (mvn verify)
  • Changes are committed by a verified email address that is assigned to the GitHub account (https://github.com/settings/emails)
  • Documentation on the tinylog website is up-to-date or updated by a pull request to the repository tinylog-org/website

Agreements

  • I agree that my changes will be published under the terms of the Apache License 2.0 (mandatory)
  • I agree that my GitHub user name will be published in the release notes (optional)

Copy link

codecov bot commented Feb 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bebb475) 94.27% compared to head (820cf5f) 94.27%.

Additional details and impacted files
@@            Coverage Diff            @@
##               v2.7     #678   +/-   ##
=========================================
  Coverage     94.27%   94.27%           
  Complexity     2833     2833           
=========================================
  Files           149      149           
  Lines          5484     5484           
  Branches        725      725           
=========================================
  Hits           5170     5170           
  Misses          176      176           
  Partials        138      138           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pmwmedia pmwmedia merged commit dffdd89 into tinylog-org:v2.7 Feb 11, 2024
2 checks passed
@pmwmedia
Copy link
Member

Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants