TINY-11482: fix tab navigation for ContextFormSlider
#10035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThis pull request introduces a new changelog entry for the TinyMCE project, documenting a fix related to keyboard navigation for the ContextFormSlider component. Additionally, it modifies the Changes
Assessment against linked issues
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
lorenzo-pomili
requested review from
a team,
hamza0867,
HAFRMO and
ztomaszyk
and removed request for
a team
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
modules/tinymce/src/themes/silver/main/ts/ui/context/ContextFormSlider.ts (1)
26-26: LGTM! Consider documenting the navigation class.The addition of 'tox-toolbar-nav-js' class enables proper tab navigation, aligning with accessibility requirements. The implementation works in conjunction with existing keyboard handlers.
Consider adding a code comment explaining the purpose of 'tox-toolbar-nav-js' class for future maintainability.
modules/tinymce/src/themes/silver/test/ts/browser/editor/contextform/ContextSliderFormTest.ts (1)
157-174: Consider enhancing keyboard navigation test coverage.While the current test effectively validates basic tab navigation, consider adding:
- Reverse navigation testing using Shift+Tab
- Verification that focus remains within the component
- Additional keyboard interaction tests (e.g., arrow keys on slider)
Here's a suggested enhancement:
it('TINY-11482: should navigate correctly via keyboard', async () => { const editor = hook.editor(); openToolbar(editor, 'test-form'); const buttonASelector = '.tox-pop button[aria-label="A"]'; const sliderSelector = '.tox-pop input'; const buttonBSelector = '.tox-pop button[aria-label="B"]'; // Forward tab navigation FocusTools.setFocus(SugarDocument.getDocument(), buttonASelector); await FocusTools.pTryOnSelector('Focus should be on the A button', SugarDocument.getDocument(), buttonASelector); TinyUiActions.keystroke(editor, Keys.tab()); await FocusTools.pTryOnSelector('Focus should be on the slider', SugarDocument.getDocument(), sliderSelector); TinyUiActions.keystroke(editor, Keys.tab()); await FocusTools.pTryOnSelector('Focus should be on the B button', SugarDocument.getDocument(), buttonBSelector); TinyUiActions.keystroke(editor, Keys.tab()); + + // Reverse tab navigation + await FocusTools.pTryOnSelector('Focus should stay on B button', SugarDocument.getDocument(), buttonBSelector); + TinyUiActions.keystroke(editor, Keys.tab(), { shiftKey: true }); + + await FocusTools.pTryOnSelector('Focus should be back on slider', SugarDocument.getDocument(), sliderSelector); + TinyUiActions.keystroke(editor, Keys.tab(), { shiftKey: true }); + + await FocusTools.pTryOnSelector('Focus should be back on A button', SugarDocument.getDocument(), buttonASelector); + + // Test arrow keys on slider + TinyUiActions.keystroke(editor, Keys.tab()); + await FocusTools.pTryOnSelector('Focus should be on slider', SugarDocument.getDocument(), sliderSelector); + TinyUiActions.keystroke(editor, Keys.right()); + const input = UiFinder.findIn<HTMLInputElement>(SugarBody.body(), sliderSelector).getOrDie(); + assert.isTrue(Number(Value.get(input)) > 37, 'Value should increase with right arrow'); });
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (3)
.changes/unreleased/tinymce-TINY-11482-2024-12-05.yaml(1 hunks)modules/tinymce/src/themes/silver/main/ts/ui/context/ContextFormSlider.ts(1 hunks)modules/tinymce/src/themes/silver/test/ts/browser/editor/contextform/ContextSliderFormTest.ts(2 hunks)
✅ Files skipped from review due to trivial changes (1)
- .changes/unreleased/tinymce-TINY-11482-2024-12-05.yaml
🔇 Additional comments (1)
modules/tinymce/src/themes/silver/test/ts/browser/editor/contextform/ContextSliderFormTest.ts (1)
1-1: LGTM! Import addition is appropriate.
The addition of Keys import is necessary for the new keyboard navigation test.
spocke
approved these changes
Dec 5, 2024
ztomaszyk
approved these changes
Dec 5, 2024
5 tasks
This was referenced Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket: TINY-11482
Description of Changes:
fix tab navigation for
ContextFormSliderPre-checks:
feature/,hotfix/orspike/Review:
Docs ticket created (if applicable)GitHub issues (if applicable):
Summary by CodeRabbit
New Features
Bug Fixes
Tests