Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TINY-10010: Empty.isEmpty should respect empty CET #9051

Merged
merged 9 commits into from
Oct 16, 2023
Merged

TINY-10010: Empty.isEmpty should respect empty CET #9051

merged 9 commits into from
Oct 16, 2023

Conversation

vpyshnenko
Copy link
Contributor

@vpyshnenko vpyshnenko commented Sep 23, 2023 •
edited
Loading

Related Ticket: TINY-10010

Description of Changes:

  • Replace in Quirks.ts DomUtils.isEmpty on Empty.isEmtpy
  • add to Empty.isEmpty function the condition to treat empty CET as a non-empty content

Pre-checks:

  • Changelog entry added
  • Tests have been added (if applicable)
  • Branch prefixed with feature/, hotfix/ or spike/

Review:

  • Milestone set
  • Docs ticket created (if applicable)

GitHub issues (if applicable):

@vpyshnenko vpyshnenko changed the title TINY-10010: add skipEmptyCET param to isEmpty function TINY-10010: Empty.isEmpty should respect empty CET Sep 24, 2023
@vpyshnenko vpyshnenko added this to the 6.8.0 milestone Sep 24, 2023
@vpyshnenko vpyshnenko self-assigned this Sep 24, 2023
@vpyshnenko vpyshnenko marked this pull request as ready for review September 24, 2023 13:03
@vpyshnenko vpyshnenko requested review from a team, spocke, lostkeys, lorenzo-pomili and hamza0867 and removed request for a team October 2, 2023 09:39
spocke
spocke approved these changes Oct 2, 2023
View reviewed changes
modules/tinymce/src/core/main/ts/dom/Empty.ts Outdated Show resolved Hide resolved
modules/tinymce/CHANGELOG.md Outdated Show resolved Hide resolved
@vpyshnenko vpyshnenko requested a review from a team as a code owner October 6, 2023 09:49
@vpyshnenko vpyshnenko requested a review from ltrouton October 6, 2023 09:49
@vpyshnenko vpyshnenko merged commit af4ac2f into develop Oct 16, 2023
3 checks passed
@vpyshnenko vpyshnenko deleted the feature/TINY-10010 branch October 16, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spocke spocke spocke approved these changes

@lorenzo-pomili lorenzo-pomili lorenzo-pomili approved these changes

@lostkeys lostkeys Awaiting requested review from lostkeys lostkeys was automatically assigned from tinymce/high-velocity

@hamza0867 hamza0867 Awaiting requested review from hamza0867 hamza0867 was automatically assigned from tinymce/high-velocity

@ltrouton ltrouton Awaiting requested review from ltrouton ltrouton was automatically assigned from tinymce/tinymce-reviewers

Assignees

@vpyshnenko vpyshnenko

Labels
None yet
Projects
None yet
Milestone
6.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@vpyshnenko @spocke @lorenzo-pomili