Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bert_XJY_ZJUT #67

Merged
merged 91 commits into from
May 8, 2021
Merged

Bert_XJY_ZJUT #67

merged 91 commits into from
May 8, 2021

Conversation

JingyangXiang
Copy link
Contributor

将Mindspore中的Bert迁移到tinyms,详情请见bert.md

@leonwanghui
Copy link
Contributor

@zjuter0126 Did u use GPU backend to train Bert network?

@JingyangXiang
Copy link
Contributor Author

@zjuter0126 Did u use GPU backend to train Bert network?

Yes,on TeslaV100-SXM2 32GB.According to mindspore,the zhwiki is used to pretrain the bert.

@leonwanghui
Copy link
Contributor

@zjuter0126 Got it, I will take a test locally later, thanks for pulling this request. And if it's possible, could u try to insert the code into the tinyms framework? Thanks!

@JingyangXiang
Copy link
Contributor Author

@zjuter0126 Got it, I will take a test locally later, thanks for pulling this request. And if it's possible, could u try to insert the code into the tinyms framework? Thanks!

I will try my best.However,I'am not sure I can insert them in tinyms beautifully.I may need to trouble you to fine-tune it later

@leonwanghui
Copy link
Contributor

@zjuter0126 Got it, I will take a test locally later, thanks for pulling this request. And if it's possible, could u try to insert the code into the tinyms framework? Thanks!

I will try my best.However,I'am not sure I can insert them in tinyms beautifully.I may need to trouble you to fine-tune it later

Don't have to worry about it, there is no trouble at all : )

@JingyangXiang
Copy link
Contributor Author

@zjuter0126 Got it, I will take a test locally later, thanks for pulling this request. And if it's possible, could u try to insert the code into the tinyms framework? Thanks!

I will try my best.However,I'am not sure I can insert them in tinyms beautifully.I may need to trouble you to fine-tune it later

Don't have to worry about it, there is no trouble at all : )

I delete some unnecessary *.py and carefully put other into tinyms frames.It may be not beautiful.You can see them in new branch.Hope this satisfies you.The usage of code is same to the former.Just please bert_for_pre_pretraining.py/config.py/utils.py in the same files. And SentimentNet's warning comes from mindspore=1.1.1.

leonwanghui
leonwanghui previously approved these changes May 7, 2021
Copy link
Contributor

@leonwanghui leonwanghui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@leonwanghui leonwanghui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@leonwanghui leonwanghui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some review comments.

tests/st/bert/bert_for_classfier.py Outdated Show resolved Hide resolved
tests/st/bert/bert_for_pre_pretraining.py Outdated Show resolved Hide resolved
tinyms/callbacks.py Outdated Show resolved Hide resolved
tinyms/data/loader.py Outdated Show resolved Hide resolved
tinyms/model/bert/__init__.py Outdated Show resolved Hide resolved
tinyms/model/bert/bert_for_finetune.py Outdated Show resolved Hide resolved
tinyms/text/transforms.py Show resolved Hide resolved
Copy link
Contributor

@leonwanghui leonwanghui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leonwanghui leonwanghui merged commit 42c3384 into tinyms-ai:main May 8, 2021
@leonwanghui
Copy link
Contributor

@zjuter0126 Congras!

@JingyangXiang JingyangXiang deleted the bert branch May 8, 2021 07:53
@JingyangXiang JingyangXiang removed their assignment May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants