Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Query killer #206

Merged
merged 13 commits into from
Apr 22, 2021
Merged

Query killer #206

merged 13 commits into from
Apr 22, 2021

Conversation

rafael
Copy link

@rafael rafael commented Apr 19, 2021 •
edited
Loading

@rafael rafael changed the title leading+trailing comment regex + file watch Query killer Apr 21, 2021
falun and others added 13 commits April 21, 2021 14:42
@falun @rafael
Some minor refactoring to support rulesctl
da9dca2 
Signed-off-by: falun <635538+falun@users.noreply.github.com>
@falun @rafael
Rough initial impl for tool to manage custom query rules
c4ddaa2 
Signed-off-by: falun <635538+falun@users.noreply.github.com>
@falun @rafael
nit
152dc71 
Signed-off-by: falun <635538+falun@users.noreply.github.com>
@falun @rafael
possibly solve lint? not sure why commit hooks aren't running
aacadf4 
Signed-off-by: falun <635538+falun@users.noreply.github.com>
@falun @rafael
Appease everybody
39ec0f1 
Signed-off-by: falun <635538+falun@users.noreply.github.com>
@rafael
leading+trailing comment regex + file watch
f89cd36 
Signed-off-by: Richard Bailey <rbailey@slack-corp.com>

Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
@rafael
route query comments into GetAction call; let filterbyplan continue t…
60c5273 
…o work as expected

Signed-off-by: Richard Bailey <rbailey@slack-corp.com>
@rafael
fix tests, register to cancel the watch
8b1fce7 
Signed-off-by: Richard Bailey <rbailey@slack-corp.com>
@rafael
copy/paste bug
1c06ea8 
Signed-off-by: Richard Bailey <rbailey@slack-corp.com>
@rafael
extend support for rulesctl + swap to battle tested file watch
490a8b9 
Signed-off-by: Richard Bailey <rbailey@slack-corp.com>
@rafael
Simplify GetAction / remove log calls
a8e58c9 
Signed-off-by: Richard Bailey <rbailey@slack-corp.com>
@rafael
gofmt
d8bf72d 
Signed-off-by: Richard Bailey <rbailey@slack-corp.com>
@rafael
Remove no longer necessary file stub creation
4396644 
Fix bug in how we attach RE to the rule in rulesctl

Signed-off-by: Richard Bailey <rbailey@slack-corp.com>
@rafael rafael force-pushed the query-killer-cherry-pick branch from 23841df to 4396644 Compare April 21, 2021 21:50
@rafael rafael merged commit ac89d87 into master Apr 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rafael @falun